Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssa: fix cvtType check types.Alias #955

Merged
merged 2 commits into from
Jan 30, 2025
Merged

ssa: fix cvtType check types.Alias #955

merged 2 commits into from
Jan 30, 2025

Conversation

visualfc
Copy link
Member

@visualfc visualfc commented Jan 13, 2025

  • fix cvtType for go1.22/1.23 GODEBUG=gotypesalias=1
  • fix compiler build for go1.22 GODEBUG=gotypesalias=1

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.61%. Comparing base (745eff0) to head (ad796eb).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
compiler/ssa/type_cvt.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #955      +/-   ##
==========================================
+ Coverage   81.58%   81.61%   +0.03%     
==========================================
  Files          53       53              
  Lines        9050     9067      +17     
==========================================
+ Hits         7383     7400      +17     
  Misses       1516     1516              
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei xushiwei merged commit cc29133 into goplus:main Jan 30, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants