Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedupe ci jobs #14

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: dedupe ci jobs #14

merged 1 commit into from
Oct 29, 2024

Conversation

agouin
Copy link
Member

@agouin agouin commented Oct 29, 2024

Fix integration and test jobs running twice per push on PRs.

@agouin agouin requested a review from Reecepbcups October 29, 2024 02:46
@mark-rushakoff
Copy link
Member

If I am following this right, opening a PR with commit A would be tested; then pushing commit B to the same branch (and therefore the same pull request) would not result in tests being run for commit B?

@agouin
Copy link
Member Author

agouin commented Oct 29, 2024

If I am following this right, opening a PR with commit A would be tested; then pushing commit B to the same branch (and therefore the same pull request) would not result in tests being run for commit B?

No, tests are run for every commit pushed to the PR still. This pattern is used in most of our other repos.

Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I see now. That was surprisingly difficult to stumble across in the documentation.

Runs your workflow when activity on a pull request in the workflow's repository occurs. For example, if no activity types are specified, the workflow runs when a pull request is opened or reopened or when the head branch of the pull request is updated.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request

@agouin agouin merged commit 46dfa8c into main Oct 29, 2024
2 checks passed
@agouin agouin deleted the andrew/ci_dedupe branch October 29, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants