Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query and tx flags default to grpc #7

Merged
merged 4 commits into from
Oct 26, 2024
Merged

fix: query and tx flags default to grpc #7

merged 4 commits into from
Oct 26, 2024

Conversation

agouin
Copy link
Member

@agouin agouin commented Oct 25, 2024

Tidier approach than #4

@agouin agouin requested a review from mark-rushakoff October 25, 2024 22:27
@agouin agouin force-pushed the andrew/query_tx_flag_opts branch from f5881ff to a20154f Compare October 25, 2024 23:28
mark-rushakoff
mark-rushakoff approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@mark-rushakoff mark-rushakoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. The approach looks reasonable to me, given the way the flags are handled in the SDK.

@agouin agouin merged commit 3df0fcc into main Oct 26, 2024
2 of 4 checks passed
@agouin agouin deleted the andrew/query_tx_flag_opts branch October 26, 2024 03:10
@agouin agouin mentioned this pull request Oct 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-rushakoff mark-rushakoff mark-rushakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agouin @mark-rushakoff