fix(deb): content file modes to support gdebi #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 70.03% 69.40% -0.63%
==========================================
Files 22 22
Lines 3080 3131 +51
==========================================
+ Hits 2157 2173 +16
- Misses 718 745 +27
- Partials 205 213 +8 ☔ View full report in Codecov by Sentry. |
erikgeiser
force-pushed
the
fix_deb_file_modes
branch
2 times, most recently
from
067a99a to
3328717
Compare
|
I'll deal with the failing acceptance test tomorrow. |
erikgeiser
force-pushed
the
fix_deb_file_modes
branch
2 times, most recently
from
9619751 to
ad400e5
Compare
erikgeiser
force-pushed
the
fix_deb_file_modes
branch
from
ad400e5 to
c137301
Compare
|
I accidentally broke mod time handling but it is fixed now. |
caarlos0
reviewed
Feb 5, 2025
caarlos0
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
aside for that one comment, lgmt
thanks for looking into this @erikgeiser 🙏
caarlos0
changed the title
caarlos0
changed the title
pull-request-size
bot
added
size/L
|
Good find. I took the time to refactor the function to avoid shadowing altogether and use the opportunity to add better error messages unique to each case. |
|
amazing, thank you @erikgeiser ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the file/dir modes in the
.debdata tar headers. When creating directory entries based on actual on-disk directories, their modes ended up including some flags that confused graphical package manager frontends (Software Installandgdebi). With this PR, the mode field in the tar header only contains the permissions, because other type information is already included in other header fields.Fixes #856.