-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use code generate for moduledata #77
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #77 +/- ##
===========================================
+ Coverage 75.52% 78.99% +3.47%
===========================================
Files 14 15 +1
Lines 2680 3480 +800
===========================================
+ Hits 2024 2749 +725
- Misses 446 514 +68
- Partials 210 217 +7 ☔ View full report in Codecov by Sentry. |
Some of code from #69. |
Very nice! I've wanted to clean up the generation code for a long time. I really appreciate this PR. There is a "bug" in the generation code for std packages that's been present since the beginning, and maybe you want to tackle it too. The logic will always use the "current" available packages from the Go repo. So when they remove internal packages or move things around, the "old" packages are removed from the list. This causes the package detection for older binaries to get worse with newer versions of Gore. The proper way to handle this would be to append only new packages to the list and not regenerate it every time. We also will have to recover the packages that has been removed and re-add them to the list. This could probably be done from Gore's git history. |
It has been implemented. Plz check the stdpkgs.go |
I'm writing an auto generate logic for moduledata. Playing with ast is not easy and may take some hours. |
Now moduledata will auto generate from golang codebase. @TcM1911 I think this PR is ready for review. |
Any updates? |
If there any problem blocking the merge process please let me know |
Sorry @Zxilly, I've just been very busy. I will take a look at this today. There are some conflicts, can you fix them? |
conflict resolved. |
I'd like to use this PR as part of the continue work of #69.
@TcM1911 Can you review this?