Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct byte order #86

Merged
merged 5 commits into from
Feb 12, 2024
Merged

use correct byte order #86

merged 5 commits into from
Feb 12, 2024

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Feb 11, 2024

Currently gore always use litte endian byte order, but for golang support arches we have ppc64 and s390x works under big endian. This patch adds support for this.

@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (7b68ef2) 78.99% compared to head (f39cc7d) 79.00%.

Files Patch % Lines
moduledata.go 57.14% 6 Missing ⚠️
file.go 57.14% 2 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #86   +/-   ##
========================================
  Coverage    78.99%   79.00%           
========================================
  Files           15       15           
  Lines         3480     3481    +1     
========================================
+ Hits          2749     2750    +1     
- Misses         514      516    +2     
+ Partials       217      215    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TcM1911
Copy link
Member

TcM1911 commented Feb 12, 2024

LGTM

@TcM1911 TcM1911 merged commit 8f57369 into goretk:develop Feb 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants