Fixed the def'n of StandardEngine, added StandardEngine2

defaultengine.go

@@ -13,7 +13,6 @@ type StdEng struct {
 
 // makeArray allocates a slice for the array
 func (e StdEng) makeArray(arr *array, t dtype.Dtype, size int) {
-
 	arr.Raw = malloc(t, size)
 	arr.t = t
 }

dense.go

@@ -84,7 +84,7 @@ func (t *Dense) makeArray(size int) {
 	case arrayMaker:
 		te.makeArray(&t.array, t.t, size)
 		return
-	case StandardEngine:
+	case StandardEngine2:
 	default:
 
 	}

engine.go

@@ -26,7 +26,16 @@ type Engine interface {
 	WorksWith(order DataOrder) bool           // WorksWith returns true if the data order can be directly worked with
 }
 
+// StandardEngine is any engine that wraps a StdEng{}.
 type StandardEngine interface {
+	StandardEngine2
+
+	// anything that wraps StdEng will contain the following interfaces:
+	arrayMaker
+}
+
+// StandardEngine2 is any engine that implements the basic operations of a standard engine.
+type StandardEngine2 interface {
 	Engine
 
 	Adder

go.mod

@@ -4,6 +4,8 @@ go 1.13
 
 replace gorgonia.org/dtype => /home/chewxy/workspace/gorgoniaws/src/gorgonia.org/dtype
 
+replace gorgonia.org/shapes => /home/chewxy/workspace/gorgoniaws/src/gorgonia.org/shapes
+
 require (
 	github.com/apache/arrow/go/arrow v0.0.0-20201229220542-30ce2eb5d4dc
 	github.com/chewxy/math32 v1.0.6
@@ -15,6 +17,7 @@ require (
 	go4.org/unsafe/assume-no-moving-gc v0.0.0-20201222180813-1025295fd063
 	gonum.org/v1/gonum v0.8.2
 	gorgonia.org/dtype v0.0.0-00010101000000-000000000000
+	gorgonia.org/shapes v0.0.0-00010101000000-000000000000
 	gorgonia.org/vecf32 v0.9.0
 	gorgonia.org/vecf64 v0.9.0
 )

go.sum

@@ -44,6 +44,8 @@ github.com/google/go-cmp v0.3.1/go.mod h1:8QqcDgzrUqlUb/G2PQTWiueGozuR1884gddMyw
 github.com/google/go-cmp v0.4.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
 github.com/google/go-cmp v0.5.0 h1:/QaMHBdZ26BB3SSst0Iwl10Epc+xhTquomWX0oZEB6w=
 github.com/google/go-cmp v0.5.0/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/gNBxE=
+github.com/google/gofuzz v1.2.0 h1:xRy4A+RhZaiKjJ1bPfwQ8sedCA+YS2YcCHW6ec7JMi0=
+github.com/google/gofuzz v1.2.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
 github.com/jung-kurt/gofpdf v1.0.3-0.20190309125859-24315acbbda5/go.mod h1:7Id9E/uU8ce6rXgefFLlgrJj/GYY22cpxn+r32jIOes=
 github.com/kisielk/errcheck v1.2.0/go.mod h1:/BMXB+zMLi60iA8Vv6Ksmxu/1UDYcXs4uQLJ+jE2L00=
 github.com/kisielk/gotool v1.0.0/go.mod h1:XhKaO+MFFWcvkIS/tQcRk01m1F5IRFswLeQ+oQHNcck=

scalar.go

@@ -8,6 +8,8 @@ import (
 	"reflect"
 	"unsafe"
 
+	"gorgonia.org/dtype"
+
 	"github.com/pkg/errors"
 	"gorgonia.org/tensor/internal/storage"
 )
@@ -87,7 +89,7 @@ func (s Scalar) GobEncode() ([]byte, error) {
 }
 func (s Scalar) GobDecode([]byte) error { return errors.Errorf(methodNYI, "GobDecode", "Scalar") } // TODO
 
-func (s Scalar) standardEngine() standardEngine { return StdEng{} }
+func (s Scalar) standardEngine() StandardEngine { return StdEng{} }
 func (s Scalar) hdr() *storage.Header           { return nil }
 func (s Scalar) arr() array                     { return array{} }
 func (s Scalar) arrPtr() *array                 { return nil }