fix: handle unnecessary invocation of handleSnapToIndex on onAnimate … #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…recreation
Please provide enough information so that others can review your pull request:
I create a ref which stores previous passed initial index and if useEffect is invoked again it checks whether the new _providedIndex actually does not equal to the old _providedIndex
Motivation
Explain the motivation for making this change. What existing problem does the pull request solve?
#2043
When we pass a prop onAnimate to BottomSheet we will encounter a bug, where onAnimate's function recreation will cause a chain of dependency changes (onAnimate -> _providedOnAnimate -> handleOnAnimate -> animateToPosition -> handleSnapToIndex -> useEffect) which will cause our BottomSheet to snap back to the initial index (which is a wrong behaviour).