Skip to content

Commit

Permalink
Add CONTRIBUTING.md (#4)
Browse files Browse the repository at this point in the history
  • Loading branch information
zhenghaoz authored Aug 1, 2023
1 parent a7231e6 commit fd0539e
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 5 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,10 @@ jobs:
name: test (Python ${{ matrix.python-version }})
strategy:
matrix:
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.9", "3.10", "3.11"]
steps:
- uses: actions/checkout@v2
- name: Build the stack
working-directory: ./tests
run: docker-compose up -d
- name: Check the deployed service health
uses: jtalk/url-health-check-action@v2
Expand Down
48 changes: 48 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
# Contribution Guide

Welcome and thank you for considering contributing to PyGorse!

Reading and following these guidelines will help us make the contribution process easy and effective for everyone involved. It also communicates that you agree to respect the time of the developers managing and developing these open source projects. In return, we will reciprocate that respect by addressing your issue, assessing changes, and helping you finalize your pull requests.

## Getting Started

### Setup Develop Environment

These following installations are required:

- **Python 3.8+**: The minimum version of Python required to run PyGorse.
- **Docker Compose**: Start a local Gorse cluster for testing.

After installing the required software, run the following commands:

```bash
# Install tox
pip install tox

# Start a local Gorse cluster
docker-compose up -d
```

### Run Unit Tests

```bash
tox
```

## Your First Contribution

### Contribution Workflow

To contribute to the Gorse code base, please follow the workflow as defined in this section.

- Fork the repository to your own Github account
- Make commits and add test case if the change fixes a bug or adds new functionality.
- Run tests and make sure all the tests are passed.
- Push your changes to a topic branch in your fork of the repository.
- Submit a pull request.

This is a rough outline of what a contributor's workflow looks like. Thanks for your contributions!

## Getting Help

Join us in the [Discord](https://discord.gg/x6gAtNNkAE) and post your question in the `#developers` channel.
File renamed without changes.
2 changes: 1 addition & 1 deletion tests/docker-compose.yml → docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ services:
MYSQL_PASSWORD: gorse_pass

gorse:
image: zhenghaoz/gorse-in-one:nightly
image: zhenghaoz/gorse-in-one
restart: unless-stopped
ports:
- 8086:8086
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@
long_description = (this_directory / "README.md").read_text()

setup(name='PyGorse',
version='0.4.7',
version='0.4.8',
description='Python SDK for gorse recommender system',
packages=['gorse'],
install_requires=['requests~=2.14.0', 'aiohttp~=3.8.3'],
install_requires=['requests>=2.14.0', 'aiohttp>=3.8.3'],
long_description=long_description,
long_description_content_type='text/markdown'
)

0 comments on commit fd0539e

Please sign in to comment.