-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mismatch parsed and output length on amd64 #2
Conversation
Could you add a test case for this PR under the tests folder. Thanks |
|
Fixes #7 |
@zhenghaoz the PR is ready and fixes both the initial issue (the empty generated lines) and an issue about different output size on amd64 |
@zhenghaoz The changes in this branch have been used in production at Weaviate for a few months now. Can I merge them and create a v0.2? |
@zhenghaoz If that's ok I will merge this PR as it dramatically improves the stability of Goat on amd64. Please let me know if you see any issue with that and I will undo it. Thanks! |
Thank you. Please release the version if you could. If you need more help, just let me know. 😁 |
Thanks @zhenghaoz ! |
While parsing asm, goat panics if a function has an empty set of lines.