Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use modern PHP standards #7

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

runelaenen
Copy link

@runelaenen runelaenen commented Oct 28, 2024

The current PHP SDK implementation lacks compatibility with modern PHP project standards, as it relies on outdated practices such as loose typing and the absence of namespaces. These limitations make it challenging to integrate the SDK effectively into new and modern PHP codebases that do follow the standards.

This Pull Request proposes a rewrite of the SDK to align it with modern PHP conventions and best practices.
Additionally, I propose expanding support to cover all available API endpoints in Gorse, as the current implementation only includes a limited subset. Before proceeding with this extended implementation, I would appreciate confirmation from the maintainer to ensure alignment with the project’s goals.

@runelaenen
Copy link
Author

runelaenen commented Oct 28, 2024

Before proceeding with this extended implementation, I would appreciate confirmation from the maintainer to ensure alignment with the project’s goals.

@zhenghaoz
I just want to make sure this is OK, as I see that there are 2 other PR's that have made some changes that are quite old and were never merged.

@zhenghaoz
Copy link
Contributor

Thank you. I think other 2 pull requests are stale. New pull requests are welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants