Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to set custom separator #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add possibility to set custom separator #27

wants to merge 3 commits into from

Conversation

matrixik
Copy link
Member

No description provided.

@matrixik
Copy link
Member Author

Not sure if I want to add this functionality. I saw some forks that have basically only one additional commit with changing separator.

Pros:

  • well, ability to set custom separator

Cons:

  • another global variable (too late to break people code)
  • IsSlug is probably slower
  • bug with regexp: compilation is happening too early so separator for it is always -

@matrixik
Copy link
Member Author

Will leave it open for now, maybe someone have some feedback.

@matrixik
Copy link
Member Author

Shit, one more bug now with defaultSubs initialized with init...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matrixik