[draft] feat: onAltGoslingSpecUpdate callback function
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sehilyi
changed the title
onAltGoslingSpecUpdateonAltGoslingSpecUpdate callback function
sehilyi
changed the title
onAltGoslingSpecUpdate callback functiononAltGoslingSpecUpdate callback function
sehilyi
commented
Jan 28, 2025
Comment on lines
+16
to
+22
| try { | ||
| // add descriptions | ||
| treeText(altSpec); | ||
| dataText(altSpec); | ||
| } catch { | ||
| console.error('Unexpected error occurred when adding descriptions'); | ||
| } |
There was a problem hiding this comment.
When using Editor examples, I was getting uncaught errors around treeText. As a workaround, I added this error handling part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not ready for review. A large part of code changes for the demo of creating AltGosling specs is not highly relevant to this PR.
This PR tries to introduce a callback function that gives the AltGosling generated descriptions. This will be useful for users to programmatically obtain those descriptions and reuse them for another purposes (e.g., generating descriptions in bulk).