Skip to content

feat: Add support for specifying URL Query params in HTTP resource #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

riton
Copy link
Contributor

@riton riton commented Jan 21, 2025

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
  • documentation is changed or added (if applicable)

Description of change

This P.R adds support for specifying URL query params in the http resource.

This will properly handle URL encoding as opposed to specifying raw query params directly in the url.


📚 Documentation preview 📚: https://goss--1013.org.readthedocs.build/en/1013/

Copy link
Member

@aelsabbahy aelsabbahy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice addition, I added one small comment regarding support for duplicate keys.

@riton riton force-pushed the feature/http_query_params branch from f14a2d1 to 6d1142d Compare May 14, 2025 05:19
@riton riton force-pushed the feature/http_query_params branch from 6d1142d to 3669540 Compare May 14, 2025 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants