feat: add callback action #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrinux
force-pushed
the
feat/add-callback-action
branch
from
68ca635 to
27c3732
Compare
cyrinux
force-pushed
the
feat/add-callback-action
branch
from
27c3732 to
4ccbd9d
Compare
jmattheis
reviewed
Jun 18, 2022
| @@ -1,5 +1,7 @@ | |||
| package com.github.gotify.service; | |||
There was a problem hiding this comment.
What's the use-case, I don't think this is needed as you can already open urls, no need to do this separately in background.
|
The use case is too trigger a callback on another api in the background when the notification is delivered on the phone. |
|
You could have a link inside the message to acknowledge that the message was received. Also, seems really insecure, sending requests in the background without user interaction. As is, I won't accept this PR, feel free to create a feature issue for this, and if enough users want this it, maybe I'll change my mind on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Me again, following my idea in #236 , you can find here the stuff to be able to do an async callback to an api when the notification is well receive.