Let lexpol controller becomes a ChampController

app/controllers/champs/lexpol_controller.rb

@@ -0,0 +1,20 @@
+module Champs
+  class LexpolController < Champs::ChampController
+
+    def upsert
+      service = LexpolService.new(champ: @champ, dossier: @champ.dossier)
+
+      force_create = params[:force_create].present?
+      nor = service.upsert_dossier(force_create: force_create)
+      if nor.present?
+        msg = @champ.value.blank? ? "Dossier Lexpol créé avec succès" :
+                                    "Dossier Lexpol mis à jour avec succès"
+        flash[:notice] = msg
+      else
+        flash[:alert] = "Impossible de #{@champ.value.blank? ? "créer" : "mettre à jour"} le dossier Lexpol."
+      end
+
+      redirect_back fallback_location: root_path
+    end
+  end
+end

config/routes.rb

@@ -222,6 +222,8 @@
 
     # TODO remove this route after august 2025
     get ':champ_id/piece_justificative/download/:h/(:i)', to: 'piece_justificative#download', as: :legacy_piece_justificative_download
+
+    post ':dossier_id/:stable_id/lexpol/upsert', to: 'lexpol#upsert', as: :lexpol_upsert_dossier
   end
 
   resources :attachments, only: [:show, :destroy]
@@ -528,7 +530,6 @@
             get 'reaffectation'
             get 'pieces_jointes'
             post 'reaffecter'
-            post 'lexpol/upsert/:champ_id', to: 'lexpol#upsert', as: :lexpol_upsert_dossier
           end
         end
 

spec/controllers/instructeurs/lexpol_controller_spec.rb

@@ -1,12 +1,13 @@
 require 'rails_helper'
 
-RSpec.describe Instructeurs::LexpolController, type: :controller do
+RSpec.describe Champs::LexpolController, type: :controller do
   render_views
 
   let(:instructeur) { create(:instructeur) }
   let(:procedure) { create(:procedure, :published, instructeurs: [instructeur]) }
   let(:dossier) { create(:dossier, procedure: procedure) }
-  let(:champ) { create(:champ, dossier: dossier) }
+  let(:value) { nil }
+  let(:champ) { create(:champ_lexpol, dossier:, value:) }
 
   before do
     allow(ENV).to receive(:fetch).and_call_original
@@ -21,72 +22,67 @@
   describe 'POST #upsert' do
     context 'when dossier creation is successful' do
       before do
-        allow(champ).to receive(:value).and_return(nil)
         allow_any_instance_of(LexpolService).to receive(:upsert_dossier).and_return('NOR-12345')
 
         post :upsert, params: {
-          procedure_id: procedure.id,
           dossier_id: dossier.id,
-          champ_id: champ.id
+          stable_id: champ.stable_id
         }
       end
 
       it 'redirects to annotations page with success message for creation' do
-        expect(response).to redirect_to(annotations_privees_instructeur_dossier_path(procedure, dossier))
-        expect(flash[:notice]).to eq('Dossier Lexpol créé avec succès. NOR : NOR-12345')
+        expect(response).to redirect_to(root_path)
+        expect(flash[:notice]).to eq('Dossier Lexpol créé avec succès')
       end
     end
 
     context 'when dossier update is successful' do
+      let(:value) { 'NOR-12345' }
       before do
-        allow(champ).to receive(:value).and_return('NOR-12345')
         allow_any_instance_of(LexpolService).to receive(:upsert_dossier).and_return('NOR-12345')
 
         post :upsert, params: {
-          procedure_id: procedure.id,
           dossier_id: dossier.id,
-          champ_id: champ.id
+          stable_id: champ.stable_id
         }
       end
 
       it 'redirects to annotations page with success message for update' do
-        expect(response).to redirect_to(annotations_privees_instructeur_dossier_path(procedure, dossier))
-        expect(flash[:notice]).to eq('Dossier Lexpol mis à jour avec succès. NOR : NOR-12345')
+        expect(response).to redirect_to(root_path)
+        expect(flash[:notice]).to eq('Dossier Lexpol mis à jour avec succès')
       end
     end
 
     context 'when dossier creation fails' do
       before do
-        allow(champ).to receive(:value).and_return(nil) # Simule un NOR vide
         allow_any_instance_of(LexpolService).to receive(:upsert_dossier).and_return(nil)
 
         post :upsert, params: {
-          procedure_id: procedure.id,
           dossier_id: dossier.id,
-          champ_id: champ.id
+          stable_id: champ.stable_id
         }
       end
 
       it 'redirects to annotations page with error message for creation' do
-        expect(response).to redirect_to(annotations_privees_instructeur_dossier_path(procedure, dossier))
+        expect(response).to redirect_to(root_path)
         expect(flash[:alert]).to eq('Impossible de créer le dossier Lexpol.')
       end
     end
 
     context 'when dossier update fails' do
+      let(:value) { 'NOR-12345' }
       before do
-        allow(champ).to receive(:value).and_return('NOR-12345')
+        champ
         allow_any_instance_of(LexpolService).to receive(:upsert_dossier).and_return(nil)
 
         post :upsert, params: {
-          procedure_id: procedure.id,
           dossier_id: dossier.id,
-          champ_id: champ.id
+          stable_id: champ.stable_id
         }
       end
 
       it 'redirects to annotations page with error message for update' do
-        expect(response).to redirect_to(annotations_privees_instructeur_dossier_path(procedure, dossier))
+        expect(response).to redirect_to(root_path)
         expect(flash[:alert]).to eq('Impossible de mettre à jour le dossier Lexpol.')
       end
     end

spec/factories/champ.rb

@@ -250,7 +250,7 @@
     end
 
     factory :champ_lexpol, class: 'Champs::LexpolChamp' do
-      type_de_champ { assocation :type_de_champ_lexpol, procedure: dossier.procedure }
+      type_de_champ { association :type_de_champ_lexpol, procedure: dossier.procedure }
     end
 
     factory :champ_cnaf, class: 'Champs::CnafChamp' do