prevent maximize when mouse double clicked #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a possible IndexOutOfBoundsException
On each push mvn verify will be executed on Ubuntu 18.04, latest MacOS and latest Windows using JDK 8
Added a github action that runs mvn verify on each push
|
Hello so basically this pull request is merging master branch into the experimental branch ? |
goxr3plus
approved these changes
Apr 6, 2021
| @@ -289,7 +290,11 @@ protected void setMoveControl(final Node node) { | |||
| } else { | |||
| //--------------------------Check here for Transparent Window-------------------------- | |||
| //Rectangle2D wholeScreen = Screen.getScreensForRectangle(m.getScreenX(), m.getScreenY(), 1, 1).get(0).getBounds() | |||
| Rectangle2D screen = Screen.getScreensForRectangle(m.getScreenX(), m.getScreenY(), 1, 1).get(0).getVisualBounds(); | |||
| ObservableList<Screen> screens = Screen.getScreensForRectangle(m.getScreenX(), m.getScreenY(), 1, 1); | |||
| if (screens.isEmpty()) { | |||
There was a problem hiding this comment.
This is a great one i haven't noticed this case :)
|
Is this pull request finished or it is work in progress? I haven't seen the fix for double mouse click on the changed code :) |
|
Having a look again today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mouse