Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eventsExecutorService thread #50

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Remove eventsExecutorService thread #50

wants to merge 26 commits into from

Commits on Sep 24, 2019

  1. Update StreamPlayer.java 

    Slight reformatting
    @HelgeStenstrom
    HelgeStenstrom committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    e023071 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded thread 

    Executors.newSingleThreadExecutor(new ThreadFactoryWithNamePrefix("StreamPlayerEvent"))); is not needed
    @HelgeStenstrom
    HelgeStenstrom committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    dfd34cd View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. Create PULL_REQUEST_TEMPLATE.md

    @goxr3plus
    goxr3plus committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    664fa3b View commit details
    Browse the repository at this point in the history

  2. Update PULL_REQUEST_TEMPLATE.md

    @goxr3plus
    goxr3plus committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    87f0f59 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2019

  1. Update README.md

    @goxr3plus
    goxr3plus committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    75f289a View commit details
    Browse the repository at this point in the history

  2. Update README.md

    @goxr3plus
    goxr3plus committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    b1e1fbe View commit details
    Browse the repository at this point in the history

  3. Update README.md

    @goxr3plus
    goxr3plus committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    06b357c View commit details
    Browse the repository at this point in the history

  4. Update README.md

    @goxr3plus
    goxr3plus committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    75b9f0d View commit details
    Browse the repository at this point in the history

  5. Update README.md

    @goxr3plus
    goxr3plus committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    4164010 View commit details
    Browse the repository at this point in the history

  6. Update README.md

    @goxr3plus
    goxr3plus committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    9da1581 View commit details
    Browse the repository at this point in the history

  7. Update README.md

    @goxr3plus
    goxr3plus committed Nov 26, 2019
    Configuration menu
    Copy the full SHA
    fb6651f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2019

  1. Update README.md

    @goxr3plus
    goxr3plus committed Nov 29, 2019
    Configuration menu
    Copy the full SHA
    987d0cd View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Update README.md

    @goxr3plus
    goxr3plus committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    6a00a79 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. minor JavaDoc and readability improvement

    @HelgeStenstrom
    HelgeStenstrom committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    719d370 View commit details
    Browse the repository at this point in the history

  2. Update StreamPlayerMethodsTest.java 

    Some unit tests are improved, but there are more to be done.
    @HelgeStenstrom
    HelgeStenstrom committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    0ef3d2f View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. AudioSystem.getMixerInfo() will not return null, so we don't have to … 

    …check for it.
    @HelgeStenstrom
    HelgeStenstrom committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    afb30bc View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. Improved and re-structured unit tests

    @HelgeStenstrom
    HelgeStenstrom committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    68c67ca View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2019

  1. Improved and more complete unit tests. 

    StreamPlayerMethodsTest still contains tests that don't pass. The tested methods are candidates for removal from StreamPlayer.

All tests in StreamPlayerMethodsTest must be reviewed: Do they actually verify anything that need to be verified? Or are they too coupled with the current implementation?

StreamPlayerFutureImprovementTest contains tests that currently fail. Failures are caused by behavior in StreamPlayer which I think is wrong or bad. But I may have misinterpreted the intended behavior.
    @HelgeStenstrom
    HelgeStenstrom committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    dca8c7a View commit details
    Browse the repository at this point in the history

  2. Merge pull request goxr3plus#59 from HelgeStenstrom/improveUnitTesting 

    Improve unit testing
    @goxr3plus
    goxr3plus committed Dec 22, 2019
    Configuration menu
    Copy the full SHA
    2905d6e View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2019

  1. Merge pull request goxr3plus#56 from HelgeStenstrom/removeNullChecks 

    AudioSystem.getMixerInfo() will not return null, so we don't have to …
    @goxr3plus
    goxr3plus committed Dec 31, 2019
    Configuration menu
    Copy the full SHA
    7f08cff View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2020

  1. Update README.md

    @goxr3plus
    goxr3plus committed Jan 1, 2020
    Configuration menu
    Copy the full SHA
    8463821 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2020

  1. Update README.md

    @goxr3plus
    goxr3plus committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    074a81b View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Update pom.xml

    @goxr3plus
    goxr3plus committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    1ec869b View commit details
    Browse the repository at this point in the history

  2. Update StreamPlayer.java 

    Slight reformatting
    @HelgeStenstrom
    HelgeStenstrom committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    b1af6cb View commit details
    Browse the repository at this point in the history

  3. Remove unneeded thread 

    Executors.newSingleThreadExecutor(new ThreadFactoryWithNamePrefix("StreamPlayerEvent"))); is not needed
    @HelgeStenstrom
    HelgeStenstrom committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    439b433 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'RemoveEventThread' of https://github.com/HelgeStenstrom… 

    …/java-stream-player into RemoveEventThread
    @HelgeStenstrom
    HelgeStenstrom committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    a742e0e View commit details
    Browse the repository at this point in the history