Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ptx parser bug when CUDART_VERSION < 6000 #127

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix ptx parser bug when CUDART_VERSION < 6000 #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/cuda-sim/ptx_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,11 @@ symbol_table *init_parser( const char *ptx_filename )
init_directive_state();
init_instruction_state();

#if (CUDART_VERSION >= 6000)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly was the error here? The Travis regressions are passing CUDA 4.2.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No error message was output, but the simulator will just be stalled without any progress.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I let this die for so long...
I am really wondering what the use-case you observed the hang in is. We regress against CUDA 4.2 (which is obviously < 6) and the code does not hang. It seems very odd to me that this code should be CUDA-version specific.

Copy link
Author

@yuchaocs yuchaocs Oct 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I let this die for so long...
I am really wondering what the use-case you observed the hang in is. We regress against CUDA 4.2 (which is obviously < 6) and the code does not hang. It seems very odd to me that this code should be CUDA-version specific.

My configuration:
OS: ubuntu 14.04.1
gcc:4.6.4
cuda:4.2
simulator config: SM2_GTX480
use-case: all workloads in ispass2009

ptx_in = fopen(ptx_filename, "r");
ptx_parse();
fclose(ptx_in);
#endif
return g_global_symbol_table;
}

Expand Down