Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatted #12

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Formatted #12

wants to merge 3 commits into from

Conversation

SuperTaiyaki
Copy link

Make --port work right as per #11

gphotofs.c Outdated
if (ret > 1) {

g_fprintf(stderr, "Multiple cameras detected on specified port. Model is required.\n");
return GP_ERROR;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the list is never freed. Here or below.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary? I'm considering this to be the same case as ret != 0, where the whole program exits immediately without proceeding to the actual mount.

gphotofs.c Outdated
return GP_ERROR;
} else if (ret < 1) {
g_fprintf(stderr, "No cameras detected on specified port.\n");
return ret;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above. cameraList is not freed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants