Make example work on touch screen as well. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Samsung Galaxy S3).
|
Sounds great, but https://github.com/tparisi/webgl-lessons is now the official version of the lessions -- you should move this PR over there. |
|
Pull request moved as advised, see tparisi#1 |
greggman
referenced
this pull request
in greggman/webgl-lessons
Aug 13, 2017
[FIX] Wrong variable use shader -> shaderProgram
greggman
referenced
this pull request
in greggman/webgl-lessons
Aug 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only tested it on Firefox and Google Chrome, both on Android on a Samsung Galaxy S3.