tagging.py: coverart rework documentation #57
Conversation
|
Is this updated and ready for review now that gpodder/gpodder#1701 has been merged? |
|
No wait, I think I need to rebase it. That should be quick. |
dconrad5
force-pushed
the
mutagen_coverart
branch
from
3803a55 to
6f5e63d
Compare
|
Ok, now it should be good to review. |
Ok, I'll try to make that clearer. |
docs/extensions/tagging.md
Outdated
| @@ -23,7 +23,7 @@ artwork will be preferred if it is present - if not, the channel artwork will be | |||
| Note that episode-specific artwork in MP4 files is currently not implemented. | |||
|
|
|||
| The artwork can optionally be normalized to the desired parameters - size and file type. | |||
| By default, it will write 500px baseline JPEGs. | |||
| By default, it will baseline JPEGs with the larger side scaled to 500px with the aspect ratio maintained. | |||
There was a problem hiding this comment.
Does "will baseline JPEGs" mean something, or was that meant to be "will write JPEGs"?
There was a problem hiding this comment.
Yeah, "baseline" is the opposite of "progressive" JPEG, that being, it will be decoded all at once rather than in increasing resolution (if I recall correctly). Maybe I should say "non-progressive" to make that more clear...?
This probably doesn't matter to people opening the files on a computer, but those with old timey mp3 players often cannot open progressive album art.
Edit: I did miss a word in there as well though, I see now...
There was a problem hiding this comment.
Yeah, "baseline" is the opposite of "progressive" JPEG, that being, it will be decoded all at once rather than in increasing resolution (if I recall correctly). Maybe I should say "non-progressive" to make that more clear...?
This probably doesn't matter to people opening the files on a computer, but those with old timey mp3 players often cannot open progressive album art.
Edit: I did miss a word in there as well though, I see now...
Done - please see d1a89c7
depends on PR #55