Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth login [WIP] #36

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

OAuth login [WIP] #36

wants to merge 3 commits into from

Conversation

stefankoegl
Copy link
Member

@stefankoegl stefankoegl commented Aug 21, 2016

Decouple gpodder.net's authentication from the application itself. This would allow other applications (eg podcast clients) to authenticate against the same source, and would also help to decouple gpodder.net into smaller components (eg a directory, subscription service, etc).

mygpo-auth functional OAuth service.

TODO

  • implement registration flow
  • move / copy users to an instance of mygpo-auth
  • Tests
  • more?

@coveralls
Copy link

coveralls commented Jul 4, 2017

Coverage Status

Coverage increased (+0.03%) to 46.431% when pulling 2e4a931 on oauth-login into 5cd52a5 on master.

@gpodder gpodder deleted a comment from coveralls Aug 6, 2017
@gpodder gpodder deleted a comment from coveralls Aug 6, 2017
@stefankoegl stefankoegl changed the title OAuth login OAuth login [WIP] Feb 2, 2020
@SiqingYu SiqingYu self-assigned this Feb 28, 2020
@SiqingYu SiqingYu self-requested a review February 28, 2020 02:28
@SiqingYu SiqingYu added the auth label Feb 28, 2020
@SiqingYu
Copy link
Contributor

The mygpo-auth implements OAuth by itself. I was wondering why not use a library like oauthlib? Security concerns could be delegated to the library instead of us.

I plan to introduce DRF in the future. I think the oauthlib integration could be helpful.

@stefankoegl
Copy link
Member Author

The mygpo-auth implements OAuth by itself. I was wondering why not use a library like oauthlib?

To be honest, I can't remember.

Security concerns could be delegated to the library instead of us.

Absolutely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants