test: add smoke test based on examples/samples-readme.md #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
thedadams,
StrongMonkey,
iwilltry42,
g-linville and
tylerslaton
|
Looks like mistral is flaking for this test. I'll check it out in a bit. |
StrongMonkey
previously approved these changes
Aug 6, 2024
njhale
force-pushed
the
test/add-readme-smoke
branch
from
faf4764
to
f7a3ab3
Compare
thedadams
previously approved these changes
Aug 6, 2024
Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
test/add-readme-smoke
branch
from
f7a3ab3
to
4d87ae0
Compare
- Regenerate golden files for existing models to drop callProgress events (we weren't comparing these anyway) - Add golden files for `gpt-4o-2024-08-06` Signed-off-by: Nick Hale <[email protected]>
- Focus comparison on matching event types to reduce false negatives - Drop "ignore callProgress" rule (we're eliding them from the event stream before sending them to the judge now) Signed-off-by: Nick Hale <[email protected]>
Signed-off-by: Nick Hale <[email protected]>
|
this is stale, will open up a new PR with the test when I get some time this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
events (we weren't comparing these anyway)
gpt-4o-2024-08-06stream before sending them to the judge now)