chore: add multiline parsing and refactor share cred behavior #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuildthecloud
force-pushed
the
multiline
branch
2 times, most recently
from
1b7c477
to
1f4bec4
Compare
g-linville
previously approved these changes
Oct 9, 2024
| @@ -16,19 +16,6 @@ func TestGPTScriptCredential(t *testing.T) { | |||
|
|
|||
| // TestCredentialScopes makes sure that environment variables set by credential tools and shared credential tools | |||
| // are only available to the correct tools. See scripts/credscopes.gpt for more details. | |||
| func TestCredentialScopes(t *testing.T) { | |||
There was a problem hiding this comment.
nit: comments should be removed too
There was a problem hiding this comment.
how funny. I think I clicked delete in goland so it just deleted the method
ibuildthecloud
force-pushed
the
multiline
branch
from
1f4bec4
to
16609bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.