Chore: Support openai o1 model #937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
commented
Jan 22, 2025
pkg/openai/client.go
Outdated
| @@ -259,8 +259,12 @@ func toMessages(request types.CompletionRequest, compat bool) (result []openai.C | |||
| } | |||
|
|
|||
| if len(systemPrompts) > 0 { | |||
| role := types.CompletionMessageRoleTypeSystem | |||
| if useO1Model { | |||
There was a problem hiding this comment.
According to docs, for o1 model it is better to use developer message.
https://platform.openai.com/docs/guides/reasoning#advice-on-prompting
StrongMonkey
commented
Jan 22, 2025
pkg/openai/client.go
Outdated
| @@ -446,6 +455,22 @@ func (c *Client) Call(ctx context.Context, messageRequest types.CompletionReques | |||
| return &result, nil | |||
| } | |||
|
|
|||
| func isO1Model(model string, envs []string) bool { | |||
There was a problem hiding this comment.
there is two ways to check whether the model is used by o1
- check if modeName is o1. This is true if used with standalone gptscript.
- Check if
OPENAI_MODEL_NAMEis set. This will be set in Obot to determine the name.
StrongMonkey
requested review from
thedadams,
njhale,
sanjay920,
iwilltry42 and
g-linville
Signed-off-by: Daishan Peng <[email protected]>
StrongMonkey
force-pushed
the
openai-o1
branch
from
062d703 to
77cb909
Compare
|
I changed the approach and move the logic to openai-model-provider. However, we still need a way to dynamically turn off stream since o1 doesn't support it. So the way to do that is to check In plain gptscript user would be expected to set that when they are using o1 model, as there is no smart way to automatically do this though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openai O1 model doesn't support stream, and doesn't support setting temperature on chat completion. We have to tweak that in order to support o1 model.
obot-platform/obot#1131