feat: s3 support path-style access #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this new configuration parameter is being correctly propagated, but I don't see where it is getting used. Also, does it make sense to have tests for this? I am trying to keep the tests up to date in this repo. |
|
@thedadams it's used for configuring the S3 client: https://github.com/gptscript-ai/workspace-provider/pull/18/files#diff-bacdf9ec88bbacf70ff21d10982757707e431edec6834b5f4be628749e1a5d35R34 |
g-linville
approved these changes
Mar 10, 2025
iwilltry42
force-pushed
the
feat/s3-path-style
branch
2 times, most recently
from
d8ca5e7 to
c0312b6
Compare
|
@thedadams - added the tests and also tested with a local MinIO instance - all seems to be working fine 👍 |
thedadams
approved these changes
Mar 13, 2025
njhale
approved these changes
Mar 13, 2025
iwilltry42
force-pushed
the
feat/s3-path-style
branch
from
c0312b6 to
9e33e0f
Compare
iwilltry42
force-pushed
the
feat/s3-path-style
branch
from
9e33e0f to
420c237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. for MinIO
Issue: obot-platform/obot#1970