Skip to content

fix: azure: format not found error message correctly #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix: azure: format not found error message correctly #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions pkg/client/azure.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ func (a *azureProvider) DeleteFile(ctx context.Context, filePath string) error {
}

func (a *azureProvider) OpenFile(ctx context.Context, filePath string, opt OpenOptions) (*File, error) {
originalFilePath := filePath
filePath = strings.TrimPrefix(filePath, "/")
if err := a.validatePath(filePath); err != nil {
return nil, err
Expand All @@ -203,7 +204,8 @@ func (a *azureProvider) OpenFile(ctx context.Context, filePath string, opt OpenO
if err != nil {
var storageErr *azcore.ResponseError
if errors.As(err, &storageErr) && storageErr.StatusCode == 404 {
return nil, newNotFoundError(fmt.Sprintf("%s://%s/%s", AzureProvider, a.containerName, a.dir), filePath)
// We need to use the original file path here, because that is how the gptscript sdk will determine whether this is a not found error.
return nil, newNotFoundError(fmt.Sprintf("%s://%s/%s", AzureProvider, a.containerName, a.dir), originalFilePath)
}
return nil, err
}
Expand Down Expand Up @@ -270,6 +272,7 @@ func (a *azureProvider) WriteFile(ctx context.Context, fileName string, reader i
}

func (a *azureProvider) StatFile(ctx context.Context, fileName string, opt StatOptions) (FileInfo, error) {
originalFileName := fileName
fileName = strings.TrimPrefix(fileName, "/")
if err := a.validatePath(fileName); err != nil {
return FileInfo{}, err
Expand All @@ -280,7 +283,8 @@ func (a *azureProvider) StatFile(ctx context.Context, fileName string, opt StatO
if err != nil {
var storageErr *azcore.ResponseError
if errors.As(err, &storageErr) && storageErr.StatusCode == 404 {
return FileInfo{}, newNotFoundError(fmt.Sprintf("%s://%s/%s", AzureProvider, a.containerName, a.dir), fileName)
// We need to use the original file name here, because that is how the gptscript sdk will determine whether this is a not found error.
return FileInfo{}, newNotFoundError(fmt.Sprintf("%s://%s/%s", AzureProvider, a.containerName, a.dir), originalFileName)
}
return FileInfo{}, err
}
Expand Down