Software texture reader swizzle test #4500
Open
+236
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turned into a bigger change than just fixing the typo. With the typo fixed, a bunch of tests started failing. One issue in particular is that out of bounds `textureLoad` needs to take swizzle into account since its allowed to return any value inside the texture. I'm making the assuption that the spec would say it can return any swizzled value in the texture. This comes up with depth textures because if texture-component-swizzle is enabled then we check RGBA for depth textures instead of just R and we expcet GBA to be 001. Before this change, if the texel address was invalid we'd get a texel from the software texture and GBA would be wrong and so no texels would match. Theoretically, with this change, the software sampler code supports swizzles but, that path is not really be exercised. Only the fact that depth textures go from R??? to R001 is used.
This is just a basic test. Other tests that would be good. * test with sampler and linear filtering * test cube maps * test gather All of these take different paths through softwareTextureRead. It's unlikely they are broken. I just wanted to check the code takes swizzle into account as that path is currently unused anywhere else. For now, it just seemed to be good to try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests as a follow up to #4498