-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reuse fragments by their selection set #437
Draft
knaeckeKami
wants to merge
12
commits into
master
Choose a base branch
from
reuse_classed_by_selection_set
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…definitions for field selections that include only a single inline fragment spread" This reverts commit 276032e.
Hey again @knaeckeKami :D And btw I had to manually modify fery_generator bcs the current version 0.8.2. expects dataClassConfig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an idea for an alternative implementation to #417
This is a different approach to reusing fragments and reduce duplication in the code.
The idea is: Keep a Map of
(TypeName ,BuiltSet<SelectionNode>) -> Reference
for already generated fragments.This will use the actual selections for figuring out whether a new class needs to be created or a fragment can be reused.
TODO: try if reusing generated subclasses for inline fragment spreads can also be optimized, without potential conflicts in types
TODO: potentially this can be extended to not only reuse fragments but all generated classes, if they have the same selections.
Drawbacks: the names of the generated classes are less stable and could change by adding new fragments which can be used
Advantage: IMO simpler to understand, easier to extend