feat: Remove requirement for bouncycastle #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… key from the EC private key
# Conflicts: # src/main/java/com/gr4vy/api/model/Transaction.java # src/main/java/com/gr4vy/api/model/TransactionPaymentMethodRequest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT DELETE THE BRANCH as it's being used for poc testing.
ACTION: Review is needed on whether we can do this without a public key - e.g. by passing the key ID .
FINDINGS: the public key is needed to build the JWSSigner, previously the public key was generated from the private key, but this caused an issue for Toursys due to their bouncycastle security provider wrapping the key as a BCECPrivateKey. Conclusion, the public key is needed and just passing the key ID alone won't help as the signer needs the public key as well.