Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix command for native compile in gradle-plugin-quickstart.adoc #633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

izeye
Copy link

@izeye izeye commented Oct 31, 2024

This PR fixes command for native compile in the gradle-plugin-quickstart.adoc.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Oct 31, 2024
@izeye izeye changed the title Fix command for native compile in gradle-plugin-quickstart.adoc Polish docs Oct 31, 2024
@izeye
Copy link
Author

izeye commented Oct 31, 2024

I added d6e9cd3 to fix the link to the fortunes.json in the maven-plugin-quickstart.adoc as it seems to have been missed in #632.

@izeye izeye changed the title Polish docs Fix command for native compile in gradle-plugin-quickstart.adoc Oct 31, 2024
@izeye
Copy link
Author

izeye commented Oct 31, 2024

I added d6e9cd3 to fix the link to the fortunes.json in the maven-plugin-quickstart.adoc as it seems to have been missed in #632.

Looking into it closely, the link that #632 fixed is not a JSON file, so I dropped the change.

@@ -213,7 +213,7 @@ graalvmNative {
+
[source,shell]
----
./gradlew nativeRun
./gradlew nativeCompile
Copy link
Member

@olyagpl olyagpl Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nativeCompile task indeed matches the step description "Compile the project and build a native executable at one step", while nativeRun compiles, builds, and runs the native executable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually plan refactoring of quick start guides to improve the user experience (already in progress). This correction would have been considered too.

@olyagpl olyagpl requested a review from dnestoro November 4, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants