feat: create read only profile page #244
Conversation
…241-create-read-only-profile-page
…241-create-read-only-profile-page
…241-create-read-only-profile-page
There was a problem hiding this comment.
Great PR! I added my comments, as well as general/design comments here:
I think it was not especially wanted to have this break effect (title-button). I think it's okay to not break, but rather use xs=10 xs=2 or 11/1
I think the display is bit strange when the public profile is empty. Maybe let's have some indication that some fields are empty?
Typo dans "membre depuis"
Also I know it was not in the mockup, but I think it would be interesting to have the link to the public profile in the read page as well.
There was a problem hiding this comment.
Good work. I have a few comments:
- change PR title to conform to the standard (for reference see the style guide)
- your PR has not been rebased, it is not dramatic, but would be better to do in the future, as it provides a clearer view of the changes you want to apply
- the Changelog has been formatted, you should not format files you do not care about. To avoid committing files you do not wish to change, review your changes locally, or in github and revert any change you do not wish to make. (Refer to the style guide for more info)
- Once you edit one part of the profile, there is no way to return back to the profile page. Add a button even if only temporary, so that users are not lost.
- In general you have repeating code, create components to re-use and make it easier to change layout more uniformly.
mariembencheikh
changed the title
There was a problem hiding this comment.
Thank you for the changes, I think I will stop bothering you. But I think you should really perform an auto-review to evaluate your code and detect potential refactoring to improve the readability and elegance of the code. This is a good exercise. If you do not find it beautiful, there is maybe a better way to do it. Just something to think about !
|
@mariembencheikh I think you should add a container inside the profile page. Recommended max size would be 1000px. |
|
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
#241