-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and collapse dataframe cells #10463
Conversation
- add expand and collapse logic
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/2448afe088585491db267d833e7f08f4b2585a91/gradio-5.14.0-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2448afe088585491db267d833e7f08f4b2585a91#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/2448afe088585491db267d833e7f08f4b2585a91/gradio-client-1.10.0.tgz Use Lite from this PR <script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/2448afe088585491db267d833e7f08f4b2585a91/dist/lite.js""></script> |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice @hannahblair! The experience is quite nice. Just a few minor points:
- I would set a
max_chars
parameter ingr.DataFrame
instead of hardcoding to 20. And by default, I would leave it asNone
to mean no truncation - I think single-select is better than double-select (also for consisntency as when the
gr.DataFrame
is interactive, a single select makes it editable which expands the content)
thanks @abidlabs - those comments have been addressed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great in my tests @hannahblair! The only issue I notice is that of column widths (the first column is much larger than the others), which can be handled separately
Co-authored-by: Abubakar Abid <[email protected]>
Description
Add expand and collapse on double click of long cell values. (Should be make it single click?)
Also, you'd notice the width awkwardness that's there already but that will be fixed in a separate PR.
Closes: #2667
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh