Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand and collapse dataframe cells #10463

Merged
merged 10 commits into from
Feb 3, 2025
Merged

Expand and collapse dataframe cells #10463

merged 10 commits into from
Feb 3, 2025

Conversation

hannahblair
Copy link
Collaborator

@hannahblair hannahblair commented Jan 29, 2025

Description

Add expand and collapse on double click of long cell values. (Should be make it single click?)

Also, you'd notice the width awkwardness that's there already but that will be fixed in a separate PR.

Closes: #2667

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

- add expand and collapse logic
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 29, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/2448afe088585491db267d833e7f08f4b2585a91/gradio-5.14.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2448afe088585491db267d833e7f08f4b2585a91#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/2448afe088585491db267d833e7f08f4b2585a91/gradio-client-1.10.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/2448afe088585491db267d833e7f08f4b2585a91/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Jan 29, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/dataframe minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Expand and collapse dataframe cells

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @hannahblair! The experience is quite nice. Just a few minor points:

  • I would set a max_chars parameter in gr.DataFrame instead of hardcoding to 20. And by default, I would leave it as None to mean no truncation
  • I think single-select is better than double-select (also for consisntency as when the gr.DataFrame is interactive, a single select makes it editable which expands the content)

@hannahblair
Copy link
Collaborator Author

thanks @abidlabs - those comments have been addressed now!

Copy link
Member

@abidlabs abidlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great in my tests @hannahblair! The only issue I notice is that of column widths (the first column is much larger than the others), which can be handled separately

@hannahblair hannahblair merged commit ed7a091 into main Feb 3, 2025
23 checks passed
@hannahblair hannahblair deleted the df-expand branch February 3, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate dataframe cell contents
3 participants