added A 'return' to growZone method #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At line 126 in Residential.js, the conditional statement checks if the residential zone meet the requirement to grow population. the growZone method should be quit if one is failed the check.
resolution issue fixed
|
Thank you so much for this pull request, and spotting these logic errors! I'll bet the temp map clearing helps with issue #21. After I merge this, I'm going to push a follow-up commit, as there was some commented out console logging left in there (I do that all the time!). The I'll try to have the version with your changes up on my URL within the next half-hour from time of writing. Sorry I took so long to get to this, and thanks, once again! |
|
Should now be live at http://graememcc.github.io/micropolisJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug which a residential zone was getting bigger without any effort. R-Zones need high population density to be promoted from 'FREEZ' tile.
At line 126 in Residential.js, the conditional statement checks if the residential zone meet the requirement to grow population. and the program should be escaped growZone method when one is failed the population density check.
previous version keep going to the next conditional statement, so the R-Zones can keep growing its population with low density.