Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to 1.22.1 #6646

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Upgrade Go to 1.22.1 #6646

merged 2 commits into from
Mar 12, 2024

Conversation

thampiotr
Copy link
Contributor

@thampiotr thampiotr commented Mar 11, 2024

PR Description

Upgrade Go to 1.22.1

Which issue(s) this PR fixes

Fixes https://github.com/grafana/agent-squad/issues/274

@thampiotr thampiotr changed the title Upgrade Go to 1.22.0 Upgrade Go to 1.22.1 Mar 11, 2024
@thampiotr thampiotr marked this pull request as ready for review March 11, 2024 13:49
Copy link
Contributor

@jcreixell jcreixell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some additional references to 1.22.0 which I think are used for builds, see https://github.com/search?q=repo%3Agrafana%2Fagent+1.22.0&type=code

I even found some stale references to 1.21 in integrations tests, which we could also update as part of this

Copy link
Contributor

@jcreixell jcreixell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think it's a good thing that we are now more specific on the patch version (in places where it wasn't specified) for consistency and to make it easier to find all references next time we need to bump

@thampiotr thampiotr merged commit 7c3372a into main Mar 12, 2024
12 checks passed
@thampiotr thampiotr deleted the thampiotr/upgrade-go branch March 12, 2024 14:37
thampiotr added a commit that referenced this pull request Mar 14, 2024
* Upgrade Go to 1.22.1

* update build images
thampiotr added a commit that referenced this pull request Mar 14, 2024
* loki.source.api: fix a bug where structured metadata is not passed downstream (#6508)

* Update build image to Go 1.22.1 (#6650)

* Upgrade Go to 1.22.1 (#6646)

* Upgrade Go to 1.22.1

* update build images

* Attempt to fix main: separate clean in windows docker images (#6671)

* Change git operations from fetch to pull (#6668)

* Update to using FETCH_HEAD since we are using FETCH which doesnt update HEAD.

* Update to using FETCH_HEAD since we are using FETCH which doesnt update HEAD.

* Use pull and not fetch

* add comments

* fix linting

* Update CHANGELOG.md

Co-authored-by: Robert Fratto <[email protected]>

---------

Co-authored-by: Robert Fratto <[email protected]>

---------

Co-authored-by: Mark Motliuk <[email protected]>
Co-authored-by: mattdurham <[email protected]>
Co-authored-by: Robert Fratto <[email protected]>
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Apr 12, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants