Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft up a way to translate otel loki receiver to flow #6782

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erikbaranowski
Copy link
Contributor

@erikbaranowski erikbaranowski commented Mar 27, 2024

PR Description

Which issue(s) this PR fixes

Closes grafana/alloy#242

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@@ -61,9 +61,15 @@ func getValueOverrideHook() builder.ValueOverrideHook {
return ConvertTargets{
Targets: value,
}
case flow_relabel.Rules:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promtail converter code does not use the common utils for this so we need to add code here

}

func toServer(cfg *lokireceiver.Protocols) server.Config {
return server.Config{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots to figure out here with how to convert the server

HTTPServerReadTimeout: 0,
HTTPServerWriteTimeout: 0,
HTTPServerIdleTimeout: 0,
GRPCListenAddress: "",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otel supports GRPC for their receiver and while ours has them wired up as flow arguments it is not supported. I created a new issue to add this support here: https://github.com/grafana/agent/issues/6783

@@ -8,7 +8,7 @@ import (
"github.com/grafana/agent/internal/component/common/loki"
"github.com/grafana/agent/internal/converter/diag"
"github.com/grafana/agent/internal/converter/internal/common"
"github.com/grafana/agent/internal/converter/internal/promtailconvert/internal/build"
"github.com/grafana/agent/internal/converter/internal/promtailconvert/build"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files all had to move in order to let the otelcol converter make use of them

@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-attention An issue or PR has been sitting around and needs attention. variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support converting lokireceiver
2 participants