Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prometheus/operator): accept relabel rules exported from prometheus.relabel #6830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hainenber
Copy link
Contributor

PR Description

Which issue(s) this PR fixes

Closes grafana/alloy#192

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added

@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. enhancement New feature or request labels Apr 9, 2024
Comment on lines +46 to +48
The `relabel_rules` argument can make use of the `rules` export value from a
[prometheus.relabel][] component to apply one or more relabeling rules to metric data points
before they're forwarded to the list of receivers in `forward_to`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `relabel_rules` argument can make use of the `rules` export value from a
[prometheus.relabel][] component to apply one or more relabeling rules to metric data points
before they're forwarded to the list of receivers in `forward_to`.
The `relabel_rules` argument uses the `rules` export value from a [prometheus.relabel][] component to apply one or more relabeling rules to your metric data points. The metric data points are relabeled and forwarded to the list of receivers in `forward_to`.

A small rework to make the information active instead of passive. Is it still technically accurate with these changes?

If this is correct, this change shoudl be applied to teh other cases here in each of the following doc topics.

@clayton-cornell clayton-cornell requested a review from a team May 1, 2024 18:55
Copy link
Contributor

github-actions bot commented Jun 1, 2024

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Jun 1, 2024
@rfratto
Copy link
Member

rfratto commented Jun 14, 2024

Hey @hainenber, sorry for leaving you hanging for so long here 😞 Unfortunately I'm not sure about the proposed functionality in grafana/alloy#192, so I'm holding off on reviewing this from an implementation standpoint.

We've recently introduced a new proposal review process that will help make it easier to understand when things still need discussion and when they're ready for work.

I'm going to mark grafana/alloy#192 as a proposal so it can be discussed and we can reach consensus on whether this is something we want to do.

@hainenber
Copy link
Contributor Author

No worries! It's always good having more opinions to a proposed addition. More code means more debts after all 🤤

@rfratto
Copy link
Member

rfratto commented Jun 14, 2024

Feel free to chime in for any proposal you think we should do, we want to welcome opinions from everyone and not just maintainers :)

@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Jun 25, 2024
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-attention An issue or PR has been sitting around and needs attention. variant/flow Relatd to Grafana Agent Flow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Relabel Rules argument to prometheus.operators.* components
3 participants