-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sec: Upgrade Ubuntu to latest LTS version #6992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thank you for the PR and apologies for the delayed review!
Do you mind also adding a changelog entry like this one please:
### Other changes
- Change the Docker base image for Linux containers to `ubuntu:noble`. (@amontalban)
I also opened a PR to make the same change in Alloy.
cc63cc8
to
259252c
Compare
Hi @ptodev, Thanks for reviewing the PR, I have just added the message to the |
Not sure why tests are failing, they work on my machine:
|
@ptodev I see that you have triggered the integration tests multiple times, any chance you can run it with debug information to see what could be wrong? I have the doubt if maybe the machine resources are not enough to spin up everything. |
Hi @amontalban 👋 Apologies for the late reply! I am taking a look today. I hope you don't mind that I will push a few commits to your branch. |
@ptodev no worries, I have been trying stuff and looks like the problem is caused by this: https://github.blog/changelog/2024-04-10-github-hosted-runner-images-deprecation-notice-docker-compose-v1/
|
Hi @amontalban, thank you very much for your contribution! Apologies that the CI was such a pain 😅 |
@ptodev thanks for the help. Just to know, when should I expect a new Docker image with this fix to be released? Thanks! |
Hi @amontalban, apologies for the late reply! I intend to make a new release next week. I'd like to update a few more things beforehand, but it won't take too much effort. |
Awesome, thank you! |
Apologies, I've been really busy and only got around to publishing the RC this week. I'm planning to publish the sable release on Wednesday next week. |
PR Description
Update Ubuntu to latest LTS as Ubuntu Mantic is EOL since July 11, 2024 (https://wiki.ubuntu.com/Releases) and Wiz.io is complaining about this.
I tested the build by running
make images
.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist