Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sec: Upgrade Ubuntu to latest LTS version #6992

Merged
merged 15 commits into from
Aug 22, 2024

Conversation

amontalban
Copy link
Contributor

PR Description

Update Ubuntu to latest LTS as Ubuntu Mantic is EOL since July 11, 2024 (https://wiki.ubuntu.com/Releases) and Wiz.io is complaining about this.

I tested the build by running make images.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@CLAassistant
Copy link

CLAassistant commented Jul 23, 2024

CLA assistant check
All committers have signed the CLA.

@amontalban
Copy link
Contributor Author

@ptodev can you please review this given you did the last image upgrade in #5537?

Thanks in advance!

Copy link
Contributor

@ptodev ptodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for the PR and apologies for the delayed review!

Do you mind also adding a changelog entry like this one please:

### Other changes

- Change the Docker base image for Linux containers to `ubuntu:noble`. (@amontalban)

I also opened a PR to make the same change in Alloy.

@amontalban
Copy link
Contributor Author

Hi @ptodev,

Thanks for reviewing the PR, I have just added the message to the CHANGELOG.md file.

@amontalban
Copy link
Contributor Author

Not sure why tests are failing, they work on my machine:

cd internal/cmd/integration-tests && GOOS=darwin GOARCH=arm64 GOARM= CGO_ENABLED=1 go run .
Building agent...
Setting up environment with Docker Compose...
Sleep for 30 seconds to ensure that the env has time to initialize...
Running tests/kafka
Running tests/otlp-metrics
Running tests/read-log-file
Running tests/redis
Running tests/scrape-prom-metrics
Running tests/unix
Cleaning up Docker environment...
Test "unix" is not applicable for this OS, ignoring
All integration tests passed!

@amontalban
Copy link
Contributor Author

@ptodev I see that you have triggered the integration tests multiple times, any chance you can run it with debug information to see what could be wrong? I have the doubt if maybe the machine resources are not enough to spin up everything.

@ptodev
Copy link
Contributor

ptodev commented Aug 16, 2024

Hi @amontalban 👋 Apologies for the late reply! I am taking a look today. I hope you don't mind that I will push a few commits to your branch.

@amontalban
Copy link
Contributor Author

@ptodev no worries, I have been trying stuff and looks like the problem is caused by this: https://github.blog/changelog/2024-04-10-github-hosted-runner-images-deprecation-notice-docker-compose-v1/

docker-compose is no longer in $PATH and therefore it was not surfaced because stdout was not logged. I just did some tests and changing docker-compose to docker compose should fix it.

@ptodev ptodev requested a review from wildum August 22, 2024 09:38
@ptodev
Copy link
Contributor

ptodev commented Aug 22, 2024

Hi @amontalban, thank you very much for your contribution! Apologies that the CI was such a pain 😅

@ptodev ptodev merged commit b9c3594 into grafana:main Aug 22, 2024
10 checks passed
@amontalban
Copy link
Contributor Author

@ptodev thanks for the help. Just to know, when should I expect a new Docker image with this fix to be released? Thanks!

@ptodev
Copy link
Contributor

ptodev commented Aug 30, 2024

@ptodev thanks for the help. Just to know, when should I expect a new Docker image with this fix to be released? Thanks!

Hi @amontalban, apologies for the late reply! I intend to make a new release next week. I'd like to update a few more things beforehand, but it won't take too much effort.

@amontalban
Copy link
Contributor Author

Hi @amontalban, apologies for the late reply! I intend to make a new release next week. I'd like to update a few more things beforehand, but it won't take too much effort.

Awesome, thank you!

@ptodev
Copy link
Contributor

ptodev commented Sep 6, 2024

Apologies, I've been really busy and only got around to publishing the RC this week. I'm planning to publish the sable release on Wednesday next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants