-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logs-config.md - structured_metadata #7026
base: main
Are you sure you want to change the base?
Conversation
According to what I was able to investigate, grafana-agent is not able to forward `structured_metadata` received from `promtail` (or another `grafana-agent` instance) to Loki. https://grafana.slack.com/archives/C01050C3D8F/p1726151855977039
@mattdurham can you do a quick validity check on this one for Agent? |
Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Looking at the code structured metadata should come through on both json and protobuf. We have a test for it here https://github.com/grafana/agent/blob/8908735a435029f915b7a7bfda1f8b9e7a3d9cd2/internal/component/loki/source/api/internal/lokipush/push_api_server_test.go |
@mattdurham does that mean the doc change proposed here is not accurate? IF someone having issues with structured metadata how can we resolve this? |
According to what I was able to investigate, grafana-agent is not able to forward
structured_metadata
received frompromtail
(or anothergrafana-agent
instance) to Loki.https://grafana.slack.com/archives/C01050C3D8F/p1726151855977039
PR Description
Let's imagine we have this scenario:
And Promtail has the following config in which we remove a label (
filename
) to add it asstructured_metadata
:And these logs are received by a grafana-agent with a config like:
filename
is not forwarded to loki asstructured_metadata
.Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist