-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm - allow loading all alloy files in /etc/alloy #1016
base: main
Are you sure you want to change the base?
Conversation
fa6c9fa
to
2558e42
Compare
@tpaschalis I updated README with helm-docs. |
For a full explanation (discussion in Slack: https://grafana.slack.com/archives/C01050C3D8F/p1718700321152549) This is the jsonnet code deploying Alloy (we use Tanka + Flux)
So basically we deploy a configmap containing multiple files in /etc/alloy (standard Alloy Helm Chart usage) Now the main issue is actually in .alloy files. So for almost all clusters pyroscope-push.alloy is:
But for some others I want to push via internal service, not over ingress, hence without auth.
In this particular environment, I then just have to override Same applies to Loki/Tempo/possibly Mimir if you use Alloy for collection. |
Basically, this PR tries to achieve what the meta k8s monitoring helm chart does: https://github.com/grafana/k8s-monitoring-helm/blob/2e2392002d17c98c100ade51e2ecaf2fa3e70a58/charts/k8s-monitoring/templates/alloy_config/_logs_service_loki.alloy.txt#L11 If/else on non "if-able" blocks |
Opened proposal: #1176 |
This PR has not had any activity in the past 30 days, so the |
PR Description
This PR implements this cli feature: 0b0b4a5
Currently, the chart only allows to load a single alloy file as an entrypoint.
This behaviour, even with modules, makes overrides or unloading components in some clusters difficult when using a common configuration.
This PR enables loading all alloy files in
/etc/alloy
(a la terraform).Configmap can then be overridden in some environments/clusters by not loading, adding some files, or only modifying the needed one.
Which issue(s) this PR fixes
Fixes #228
Notes to the Reviewer
PR Checklist