Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explicit chown step that made docker image bigger #1101

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

captncraig
Copy link
Contributor

@captncraig captncraig commented Jun 21, 2024

Before (v1.1): 544MB (according to docker desktop)

# ls -la /bin/alloy
-rwxr-xr-x 1 alloy alloy 228652376 May 30 14:17 /bin/alloy
# ls -la /var/lib/alloy
total 12
drwxrwx--- 1 alloy alloy 4096 May 30 14:17 .
drwxr-xr-x 1 root  root  4096 May 30 14:17 ..
drwxrwx--- 1 alloy alloy 4096 May 30 14:17 data
# ls -la /etc/alloy
total 12
drwxr-xr-x 1 alloy alloy 4096 May 30 14:17 .
drwxr-xr-x 1 root  root  4096 Jun 21 15:27 ..
-rw-r--r-- 1 alloy alloy  748 May 30 14:13 config.alloy

After: 408MB

# ls -la /bin/alloy
-rwxr-xr-x 1 alloy alloy 321554776 Jun 21 15:32 /bin/alloy
# ls -la /var/lib/alloy
total 20
drwxrwx--- 1 alloy alloy 4096 Jun 21 15:21 .
drwxr-xr-x 1 root  root  4096 Jun 21 15:21 ..
drwxrwx--- 1 alloy alloy 4096 Jun 21 15:21 data
# ls -la /etc/alloy
total 12
drwxr-xr-x 2 alloy alloy 4096 Jun 21 15:21 .
drwxr-xr-x 1 root  root  4096 Jun 21 15:23 ..
-rw-rw-r-- 1 alloy alloy  748 Mar 29 03:34 config.alloy

It isn't a massive improvement, but it is something for free.

@captncraig
Copy link
Contributor Author

Fixes #1096

@ptodev ptodev merged commit e000bbf into main Jun 24, 2024
20 checks passed
@ptodev ptodev deleted the cmp_small_docker branch June 24, 2024 07:25
ToonTijtgat2 pushed a commit to ToonTijtgat2/alloy that referenced this pull request Jul 3, 2024
* remove explicit chown step that made docker image bigger

* remove chmod
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants