Add otelcol.processor.groupbyattrs component
#1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@grafana/grafana-alloy-maintainers Can we do a code review before I review the doc? |
wildum
reviewed
Jul 16, 2024
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
internal/component/otelcol/processor/groupbyattrs/groupbyattrs.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/processor/groupbyattrs/groupbyattrs.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/processor/groupbyattrs/groupbyattrs.go
Outdated
Show resolved
Hide resolved
internal/component/otelcol/processor/groupbyattrs/groupbyattrs.go
Outdated
Show resolved
Hide resolved
|
You will also need to add a config converter for the component. You can follow the pattern used for the other otel components in https://github.com/grafana/alloy/tree/main/internal/converter/internal/otelcolconvert |
- Use Generally avaialble stability - Import Correct package
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
# Conflicts: # CHANGELOG.md # go.mod # go.sum
|
@wildum could you please take another look? |
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Clayton Cornell <[email protected]>
wildum
reviewed
Aug 2, 2024
There was a problem hiding this comment.
the code looks good to me, I just have some little feedback on the doc. I found that the examples in the original doc were helpful to understand how the processor work. Should we add some examples or is it already clear enough? @ptodev I think you also wanted to give some feedback on this PR?
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
internal/component/otelcol/processor/groupbyattrs/groupbyattrs.go
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
ptodev
reviewed
Aug 5, 2024
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Show resolved
Hide resolved
internal/converter/internal/otelcolconvert/testdata/groupbyattrs.alloy
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
internal/component/otelcol/processor/groupbyattrs/groupbyattrs.go
Outdated
Show resolved
Hide resolved
…rs.alloy Co-authored-by: Paulin Todev <[email protected]>
…nto otelcol-processor-groupbyattr # Conflicts: # docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md # internal/converter/internal/otelcolconvert/testdata/groupbyattrs.alloy
|
Thanks for the review team. I'm sorry the second set of changes came a bit later. I have been busy. |
ptodev
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Thank you, @kehindesalaam! When @clayton-cornell approves it and when the CI is green, I'm happy for the PR to be merged!
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.groupbyattrs.md
Outdated
Show resolved
Hide resolved
…oupbyattrs.md Co-authored-by: Paulin Todev <[email protected]>
…oupbyattrs.md Co-authored-by: Paulin Todev <[email protected]>
…oupbyattrs.md Co-authored-by: Paulin Todev <[email protected]>
Allzz77123
approved these changes
Aug 21, 2024
ptodev
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Thank you! Looks good to me. 🚢 I just pushed a commit on your branch with a few minor docs fixes. By the way, you can visualise the docs in a browser by running these commands:
cd docs
make docs
I find this very useful when I want to make sure everything gets rendered appropriately.
clayton-cornell
added
the
type/docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds the
otelcol.processor.groupbyattrscomponent which allows grouping of metrics matching specific attributes.Which issue(s) this PR fixes
Fixes #224
Notes to the Reviewer
PR Checklist