Cluster peer discovery improvements and fixes #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
force-pushed
the
thampiotr/cluster-dns-queries-v2
branch
2 times, most recently
from
920382e
to
d722910
Compare
thampiotr
force-pushed
the
thampiotr/cluster-discovery-v2-changes
branch
2 times, most recently
from
f59b725
to
5dc6265
Compare
thampiotr
force-pushed
the
thampiotr/cluster-discovery-v2-changes
branch
4 times, most recently
from
533534e
to
5b4981e
Compare
thampiotr
changed the base branch from
main
to
revert-1390-revert-1311-thampiotr/cluster-dns-queries-v2
thampiotr
force-pushed
the
thampiotr/cluster-discovery-v2-changes
branch
from
5b4981e
to
cf0e5d2
Compare
Base automatically changed from
revert-1390-revert-1311-thampiotr/cluster-dns-queries-v2
to
main
August 2, 2024 10:25
thampiotr
force-pushed
the
thampiotr/cluster-discovery-v2-changes
branch
from
cf0e5d2
to
d29900b
Compare
thampiotr
changed the title
|
Will put some eyes on this tomorrow. |
mattdurham
approved these changes
Aug 9, 2024
thampiotr
force-pushed
the
thampiotr/cluster-discovery-v2-changes
branch
from
3a0133b
to
5b991c6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Continuation of #1394.
Clustering peer resolution through
--cluster.join-addressesflag has beenimproved with more consistent behaviour, better error handling and added
support for A/AAAA DNS records. If necessary, users can temporarily opt out of
this new behaviour with the
--cluster.use-discovery-v1, but this can only beused as a temporary measure, since this flag will be disabled in future
releases.
Fixed an issue where providing multiple hostnames or IP addresses
via
--cluster.join-addresseswould only use the first provided value.Fixed an issue where providing
<hostname>:<port>in
--cluster.join-addresseswould only resolve with DNS to a single address,instead of using all the available records.
Fixed an issue where clustering peers resolution via hostname in
--cluster.join-addressesresolves to duplicated IP addresses when using SRV records.
Added more tests to cover the above
Refactored for readability (separate commit from test changes, verified tests pass)
Improved error handling, logging and added tracing.
Which issue(s) this PR fixes
#1208
PR Checklist