Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster peers per instance panel to cluster overview dash #1455

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

thampiotr
Copy link
Contributor

@thampiotr thampiotr commented Aug 12, 2024

PR Description

This adds a breakdown of number of peers seen by each instance in cluster overview. It can be invaluable in quickly diagnosing cluster split brain issues and which instances are affected.

For example this issue: #1208

Which issue(s) this PR fixes

Fixes #1208

Notes to the Reviewer

Tested locally with grr

PR Checklist

  • CHANGELOG.md updated

@thampiotr thampiotr force-pushed the thampiotr/add-instance-peers-panel branch from e8055a9 to fb44710 Compare August 12, 2024 16:33
@thampiotr thampiotr marked this pull request as ready for review August 12, 2024 16:39
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@thampiotr thampiotr merged commit 0ea8f05 into main Aug 13, 2024
18 checks passed
@thampiotr thampiotr deleted the thampiotr/add-instance-peers-panel branch August 13, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[clustering] failure to discover peers when the number of instances and exposed ports is large
3 participants