-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new env vars #1481
Merged
Merged
Add new env vars #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I gave it a go at defining the PPROF env vars.
|
Its accurate, though these things are confusing by design. By default we currently profile 1/1000 or 0.01%. |
mattdurham
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its not clean but the underlying code isnt clean either, better to have them documented than not.
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 643a055)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 643a055)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 643a055)
github-actions bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 643a055)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport release/v1.0
backport release/v1.1
backport release/v1.2
backport release/v1.3
type/docs
Docs Squad label across all Grafana Labs repos
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds two new env vars.
Which issue(s) this PR fixes
Fixes #1190
Notes to the Reviewer
PR Checklist