Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new env vars #1481

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Add new env vars #1481

merged 2 commits into from
Aug 19, 2024

Conversation

clayton-cornell
Copy link
Contributor

PR Description

This PR adds two new env vars.

Which issue(s) this PR fixes

Fixes #1190

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@clayton-cornell
Copy link
Contributor Author

I gave it a go at defining the PPROF env vars.

  • Are the descriptions accurate and do they make sense?
  • The default value for PPROF_MUTEX_PROFILING_PERCENT seems incorrect.

@clayton-cornell clayton-cornell requested a review from a team August 19, 2024 14:40
@mattdurham
Copy link
Collaborator

Its accurate, though these things are confusing by design. By default we currently profile 1/1000 or 0.01%.

mattdurham
mattdurham approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not clean but the underlying code isnt clean either, better to have them documented than not.

@clayton-cornell clayton-cornell merged commit 643a055 into main Aug 19, 2024
18 checks passed
@clayton-cornell clayton-cornell deleted the docs/add-PPROF-env-var branch August 19, 2024 15:23
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
@clayton-cornell @grafanabot
Add new env vars (#1481)
72e5de6 
(cherry picked from commit 643a055)
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
@clayton-cornell @grafanabot
Add new env vars (#1481)
b3de6c6 
(cherry picked from commit 643a055)
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
@clayton-cornell @grafanabot
Add new env vars (#1481)
2da8277 
(cherry picked from commit 643a055)
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
@clayton-cornell @grafanabot
Add new env vars (#1481)
a4600b8 
(cherry picked from commit 643a055)
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdurham mattdurham mattdurham approved these changes

Assignees
No one assigned
Labels
backport release/v1.0 backport release/v1.1 backport release/v1.2 backport release/v1.3 type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PPROF_MUTEX_PROFILING_PERCENT env var details
2 participants
@clayton-cornell @mattdurham