feat: Add intervalprocessor component #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's my very first time reading alloy's codebase, so bear with me if I missed anything 😅. I'm seeing errors when testing this locally, but I'm struggling a bit to understand why |
clayton-cornell
added
the
type/docs
|
@grafana/grafana-alloy-maintainers I'll circle back to do a doc review once the code base is reviewed. |
ptodev
reviewed
Aug 19, 2024
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
|
I do not understand the test failure, I haven't changed anything on the test or on the files used in this test 🤔 |
|
The OSX tests are always flaky and dont stop a merge. Will see what drone reports on the linux tests. |
mattdurham
reviewed
Aug 20, 2024
| @@ -421,7 +421,7 @@ require ( | |||
| github.com/go-openapi/validate v0.23.0 // indirect | |||
| github.com/go-redis/redis/v8 v8.11.5 // indirect | |||
| github.com/go-resty/resty/v2 v2.13.1 // indirect | |||
| github.com/go-viper/mapstructure/v2 v2.0.0-alpha.1 // indirect | |||
| github.com/go-viper/mapstructure/v2 v2.0.0 // indirect | |||
There was a problem hiding this comment.
The error is from this line, how the mapstructure reports errors has changed. You need to update the verbiage in the corrupt_config.diags to match the new error it reports.
mattdurham
approved these changes
Aug 20, 2024
clayton-cornell
approved these changes
Aug 26, 2024
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.processor.interval.md
Outdated
Show resolved
Hide resolved
Thanks for taking a look! |
|
@ArthurSens can you resolve the conflicts and I will set it to automerge. |
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: Paulin Todev <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
ArthurSens
force-pushed
the
intervalprocessor
branch
from
566ef9b
to
ca90b70
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Adds intervalprocessor as a new component to alloy.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist