Fix typo in docs components.md #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I understood correctly, the component is "local.file" and its name (?) is "api_key" so the comment seemed to have a typo.
fridgepoet
commented
Sep 10, 2024
Co-authored-by: Shirley <[email protected]>
clayton-cornell
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Good catch @fridgepoet Looks like a simple copy-paste error crept into the content. Than happens and they can be hard to spot some days... so thank you for submitting the PR.
I committed your alternate suggestion as I agree, that's more correct here.
clayton-cornell
added
type/docs
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Shirley <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 44282cc)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Shirley <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 44282cc)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Shirley <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 44282cc)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Co-authored-by: Shirley <[email protected]> Co-authored-by: Clayton Cornell <[email protected]> (cherry picked from commit 44282cc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
If I understood correctly, the component is "local.file" and its label is "api_key" so the comment seemed to have a typo. Let me know if I have misunderstood!
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist