Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of tests which were failing on the main branch since #1527 was merged.
One test was about pointer reuse:
The other failing tests were for the converters. The integration tests wanted to add
smb
andsmb_client
Alloy config, because thesplit
function would output a[""]
instead of[]
, and the converter tests thought that Alloy's defaults are different from static mode's defaults.Btw static mode doesn't even support these
smb
andsmb_client
parameters... But I'm not 100% how to ignore them right now, so I'll leave this for another day 😄 It's not really important, since no one who uses static mode would set them in their config anyway.