Add lifecycle and terminationGracePeriodSeconds for daemonset #1674
Conversation
jianpingzhangBill
commented
Sep 12, 2024
jianpingzhangBill
commented
- CHANGELOG.md updated
- Documentation added
- Tests updated
- Config converters updated
|
|
|
This feels reasonable but would love people more familiar to give some input @petewall or @captncraig |
| @@ -57,6 +57,10 @@ | |||
| scheme: {{ $values.listenScheme }} | |||
| initialDelaySeconds: 10 | |||
| timeoutSeconds: 1 | |||
| {{- with $values.lifecycle }} | |||
| lifecycle: | |||
There was a problem hiding this comment.
Is this supposed to set a lifecycle on the Pod spec?
There was a problem hiding this comment.
% kubectl explain pod.spec.lifecycle
KIND: Pod
VERSION: v1
error: field "lifecycle" does not exist
There was a problem hiding this comment.
➜ ~ kubectl explain pod.spec.containers.lifecycle
KIND: Pod
VERSION: v1
FIELD: lifecycle
DESCRIPTION:
Actions that the management system should take in response to container
lifecycle events. Cannot be updated.
Lifecycle describes actions that the management system should take in
response to container lifecycle events. For the PostStart and PreStop
lifecycle handlers, management of the container blocks until the action is
complete, unless the container process fails, in which case the handler is
aborted.
FIELDS:
postStart
PostStart is called immediately after a container is created. If the handler
fails, the container is terminated and restarted according to its restart
policy. Other management of the container blocks until the hook completes.
More info:
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#container-hooks
preStop
PreStop is called immediately before a container is terminated due to an API
request or management event such as liveness/startup probe failure,
preemption, resource contention, etc. The handler is not called if the
container crashes or exits. The Pod's termination grace period countdown
begins before the PreStop hook is executed. Regardless of the outcome of the
handler, the container will eventually terminate within the Pod's
termination grace period (unless delayed by finalizers). Other management of
the container blocks until the hook completes or until the termination grace
period is reached. More info:
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#container-hooks
operations/helm/charts/alloy/templates/controllers/daemonset.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Pete Wall <[email protected]>
Co-authored-by: Pete Wall <[email protected]>
| @@ -57,6 +57,10 @@ | |||
| scheme: {{ $values.listenScheme }} | |||
| initialDelaySeconds: 10 | |||
| timeoutSeconds: 1 | |||
| {{- with $values.lifecycle }} | |||
| lifecycle: | |||
There was a problem hiding this comment.
➜ ~ kubectl explain pod.spec.containers.lifecycle
KIND: Pod
VERSION: v1
FIELD: lifecycle
DESCRIPTION:
Actions that the management system should take in response to container
lifecycle events. Cannot be updated.
Lifecycle describes actions that the management system should take in
response to container lifecycle events. For the PostStart and PreStop
lifecycle handlers, management of the container blocks until the action is
complete, unless the container process fails, in which case the handler is
aborted.
FIELDS:
postStart
PostStart is called immediately after a container is created. If the handler
fails, the container is terminated and restarted according to its restart
policy. Other management of the container blocks until the hook completes.
More info:
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#container-hooks
preStop
PreStop is called immediately before a container is terminated due to an API
request or management event such as liveness/startup probe failure,
preemption, resource contention, etc. The handler is not called if the
container crashes or exits. The Pod's termination grace period countdown
begins before the PreStop hook is executed. Regardless of the outcome of the
handler, the container will eventually terminate within the Pod's
termination grace period (unless delayed by finalizers). Other management of
the container blocks until the hook completes or until the termination grace
period is reached. More info:
https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/#container-hooks
